Skip to content

Conversation

@ooooo-create
Copy link
Contributor

Description

Adds --skip-tags argument to cli.

Motivation and Context

fixes #1313

How Has This Been Tested?

Add a new fixture in .github/fixtures/test-cli-arg-skip-tags according to .github/fixtures/README.md.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copilot AI review requested due to automatic review settings January 2, 2026 17:07
@ooooo-create ooooo-create requested a review from orhun as a code owner January 2, 2026 17:07
@welcome
Copy link

welcome bot commented Jan 2, 2026

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new --skip-tags CLI argument to git-cliff, allowing users to skip specific tags matching a regex pattern in the generated changelog. This complements the existing --ignore-tags functionality.

Key Changes:

  • Added new skip_tags CLI argument with environment variable support
  • Integrated the argument into the configuration processing logic
  • Added comprehensive test fixtures to validate the functionality

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
git-cliff/src/args.rs Defines the new skip_tags CLI argument with proper clap attributes
git-cliff/src/lib.rs Processes the skip_tags argument and updates the configuration
website/docs/usage/args.md Documents the new CLI argument (contains naming inconsistency)
website/docs/configuration/git.md Documents the configuration override (contains naming inconsistency)
.github/workflows/test-fixtures.yml Adds test case for the new argument
.github/fixtures/test-cli-arg-skip-tags/expected.md Expected output for the test fixture
.github/fixtures/test-cli-arg-skip-tags/commit.sh Test setup script creating commits and tags
.github/fixtures/test-cli-arg-skip-tags/cliff.toml Configuration file for the test fixture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.40%. Comparing base (0cec8a0) to head (6fdc138).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   43.48%   43.40%   -0.08%     
==========================================
  Files          23       23              
  Lines        2245     2247       +2     
==========================================
- Hits          976      975       -1     
- Misses       1269     1272       +3     
Flag Coverage Δ
unit-tests 43.40% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun orhun merged commit 32cf8c5 into orhun:main Jan 8, 2026
96 checks passed
@welcome
Copy link

welcome bot commented Jan 8, 2026

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it possible to overide skip_tags with CLI options?

3 participants