Include font_management in wheel py-modules#237
Open
datalifenyc wants to merge 1 commit into
Open
Conversation
pip-installing from git builds a wheel containing only create_map_poster; importing it then fails with ModuleNotFoundError: No module named 'font_management', since font_management.py is never packaged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing maptoposter as a package (e.g.
pip install git+https://github.com/originalankur/maptoposter.git) produces a wheel that contains onlycreate_map_poster.py. Importing it then fails immediately:font_management.pylives at the repo root next tocreate_map_poster.py, but[tool.setuptools] py-moduleslists onlycreate_map_poster, so the wheel never includes it. Running from a source checkout hides the bug (the sibling file resolves via cwd), which is why the CLI works in-repo but the installed package is broken.Fix
Add
font_managementtopy-modulesso both top-level modules ship in the wheel.Verified locally on Windows/Python 3.13:
pip installfrom this branch →python -m create_map_poster --city "Galway" --country "Ireland" ...renders a poster; installing from currentmainreproduces theModuleNotFoundError.🤖 Generated with Claude Code