Options: setFillRawValues() -> setTrackRawValues()

orisai · May 6, 2023 · fcde9c6 · fcde9c6
1 parent 3be4b48
commit fcde9c6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/src/Processing/DefaultProcessor.php b/src/Processing/DefaultProcessor.php
@@ -619,7 +619,7 @@ private function fillObject(
 		$meta = $callContext->getMeta();
 
 		// Set raw data
-		if ($options->isFillRawValues()) {
+		if ($options->isTrackRawValues()) {
 			$this->rawValuesMap->setRawValues($object, $rawData);
 		}
 
@@ -657,9 +657,6 @@ private function createHolder(string $class, ClassRuntimeMeta $meta, ?MappedObje
 		return new ObjectHolder($this->objectCreator, $meta, $class, $object);
 	}
 
-	/**
-	 * @return mixed
-	 */
 	public function getRawValues(MappedObject $object)
 	{
 		return $this->rawValuesMap->getRawValues($object);

diff --git a/src/Processing/Options.php b/src/Processing/Options.php
@@ -17,7 +17,7 @@ final class Options
 
 	private bool $prefillDefaultValues = false;
 
-	private bool $fillRawValues = false;
+	private bool $trackRawValues = false;
 
 	/** @var array<class-string, object> */
 	private array $dynamicContexts = [];
@@ -68,20 +68,14 @@ public function isPrefillDefaultValues(): bool
 		return $this->prefillDefaultValues;
 	}
 
-	/**
-	 * Make user-sent values accessible by $mappedObject->getRawValues()
-	 * Used only if objects are initialized
-	 * Use only for debug, it may lead to significant raw data grow in bigger hierarchies
-	 * 		 you can set data to a custom property in before class callback, if are always needed
-	 */
-	public function setFillRawValues(bool $fill = true): void
+	public function setTrackRawValues(bool $fill = true): void
 	{
-		$this->fillRawValues = $fill;
+		$this->trackRawValues = $fill;
 	}
 
-	public function isFillRawValues(): bool
+	public function isTrackRawValues(): bool
 	{
-		return $this->fillRawValues;
+		return $this->trackRawValues;
 	}
 
 	public function addDynamicContext(object $context): void

diff --git a/tests/Unit/Processing/DefaultProcessorTest.php b/tests/Unit/Processing/DefaultProcessorTest.php
@@ -455,7 +455,7 @@ public function testInitialization(): void
 	public function testTransformation(): void
 	{
 		$options = new Options();
-		$options->setFillRawValues();
+		$options->setTrackRawValues();
 
 		$data = [
 			'bool' => 'true',
@@ -697,7 +697,7 @@ public function testPropertyCallbacksFailure(): void
 	public function testBeforeClassCallbackMixedValue(): void
 	{
 		$options = new Options();
-		$options->setFillRawValues();
+		$options->setTrackRawValues();
 
 		$vo = null;
 		$exception = null;