Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: correct ADIOS2_Blosc2_PREFER_SHARED behavior #3767

Merged

Conversation

vicentebolea
Copy link
Collaborator

Fixes: #3766

@vicentebolea vicentebolea changed the title cmake: correct prefer_shared_blosc behavior cmake: correct ADIOS2_Blosc2_PREFER_SHARED behavior Aug 16, 2023
@vicentebolea
Copy link
Collaborator Author

@ax3l can you review this

Copy link
Contributor

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! :)

@ax3l

This comment was marked as resolved.

@ax3l

This comment was marked as resolved.

@ax3l

This comment was marked as off-topic.

@vicentebolea vicentebolea merged commit 8706b56 into ornladios:master Aug 22, 2023
29 checks passed
@vicentebolea vicentebolea deleted the correct-blosc-prefer-shared branch August 22, 2023 19:58
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ADIOS2_Blosc2_PREFER_SHARED behavior
2 participants