-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FindBlosc2 #3910
Remove FindBlosc2 #3910
Conversation
d8f1a9e
to
6e70723
Compare
@ax3l thansk for the contribution, we still support blosc2 >= 2.4 without problems. I think that the issues that you found are due to the fact that blosc2 could not be installed due to depedencies missing and using as a backup this FindBlosc file. |
6e70723
to
0e20406
Compare
I rebased on the top of master, there was some unrelated CI failures in master for a two weeks. |
Thanks @vicentebolea
I cannot see a c-blosc2 install issue here: |
0e20406
to
ff698a2
Compare
It doesn't hurt to increase the version requirement for blosc2. |
Note that we might not have an issue with our current FindBlosc2.cmake file. The error that @ax3l have been seeing it seems to be unrelated to this file. The error that was reported at #3903 seems to be related to the blosc2config.cmake not to be found. We might not want to arbitrarily drop dependency to older c-blosc2 since dependending on its last release might hinder users that do not have access to older c-blocs2 versions. |
This was already done at #4093. Closing |
Going forward, it might be easier if we dump the dependency to 2.10.2+
https://github.com/Blosc/c-blosc2/releases/tag/v2.10.2
Related to #3903