-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try 32bits in windows #4125
Try 32bits in windows #4125
Conversation
Hmm... Didn't end up showing the errors that Axel was getting... Wonder why... |
441f595
to
ce8e777
Compare
hmm I changed in a non used cmake file. Lets remove them. |
@eisenhauer our 32bits got new errors 🎉 |
Oddly, still not the warnings that Axel reported, but different ones. But it's a start, I'll poke at these. |
152ef13
to
643a88c
Compare
Hmm. Still haven't sorted this WSAGetLastError redefinition thing. I thought it might be the order or include files, but that doesn't seem to have change anything. At some point I'll have to try this on an actual windows box and see if I can reproduce. Also, the warnings reported in Issue #4105 aren't appearing here, so we've still got those to sort. |
In case we have the chance to get this merged, still appreciate the coverage :) |
The challenge unfortunately is far beyond getting this to compile on 32-bits. I suspect that the assumption that size_t is corresponds to 64-bits may be deeply embedded and may be quite difficult to sort out. Merging this before sorting that would be problematic. Getting ADIOS to the point where it runs cleanly on both 32 and 64 bit systems might be even more so. |
fac517d
to
7db5d0c
Compare
Closing this since this work would require a much greater amount of engineering (compatibility between bp file produced in different arch for instance) |
cc @eisenhauer