-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rtt_tf to tf2 #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only have a few comments and requests:
- Static transforms have to be added as such to
tf2::BufferCore::setTransform()
. - I suggest to add support for broadcasting static transforms, too.
- Remove commented/obsolete code
Not covered by comments below:
rtt_tf
needs to depend on the new typekit packagertt_tf2_msgs
. Include the generated headerrtt_tf2_msgs/typekit/Types.hpp
instead oftf2_msgs/TFMessage.h
, which declares the template instantiations forRTT::InputPort<tf2_msgs::TFMessage>
andRTT::OutputPort<tf2_msgs::TFMessage>
as external. This pattern should always be used for types that have a typekit to reduce binary sizes and save compilation time.- Update rtt_tf/package.xml and rtt_tf/CMakeLists.txt. At the moment it only works because
tf
depends ontf2_ros
internally. We can keep the dependency totf
and still usetf::resolve()
instead of copying the method.
When adding new or updating operations of the component, please do not forget to also update the public tf_interface.h, too.
…loads a component that allows importing ROS packages following the dependency tree.
Addressed most issues, but as we discussed earlier, some bigger changes should be addressed as a separate PR. See issue created to discuss this: #126 |
… other minor cleanups
…c transform case; remove dead code
…form(s) operations
a9e9bed
to
cedde0c
Compare
c0fcf74
to
9a864ec
Compare
This branch ports rtt_tf to be now based on tf2. It also allows subscribing to static transforms as input.
As requested in issue #68.