Skip to content

Fix errors on keys removal #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomanDashchakivskyi-TomTom wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix errors on keys removal #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c748c8
Prevent exception on successful keys removal
RomanDashchakivskyi-TomTom Dec 19, 2022
8742e94
Prevent error when removing keys from project without keys
RomanDashchakivskyi-TomTom Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/pod/command/keys/rm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,19 @@ def run
raise Informative, 'Could not find a project to remove the key from.'
end

unless keyring.keys.count > 0
UI.puts "Project does not have keys to remove."
return
end

if @wipe_all
@key_name = '*'
end

matching_keys = matches(keyring.keys)
if matching_keys.count > 0
messages = matching_keys.map { |e| delete_key(e, keyring) }
raise Informative, messages.join("\n")
UI.puts messages.join("\n") unless config.silent?
else
raise Informative, "Could not find key that matched \"#{@key_name}\"."
end
Expand Down