Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: makes Courier http doc consistent with kratos configuration #1475

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

adamstrawson
Copy link
Contributor

The documentation is inconsistent with the format Kratos configuration expects, this PR brings them inline.

  1. headers is plural in the schema
 "headers": {
          "type": "object",
          "description": "The HTTP headers that must be applied to request",
          "additionalProperties": {
            "type": "string"
          }
        },
  1. email.strategy was later replaced with delivery_strategy

Related Issue or Design Document

ory/kratos#3392

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@adamstrawson adamstrawson changed the title Makes Courier http doc consistent with kratos configuration docs: makes Courier http doc consistent with kratos configuration Jul 25, 2023
Copy link
Contributor

@kmherrmann kmherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kmherrmann kmherrmann merged commit 5457e3c into ory:master Jul 26, 2023
5 checks passed
@adamstrawson adamstrawson deleted the patch-1 branch July 26, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants