-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: redirect duplicate doc #1488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinckr
requested review from
kmherrmann,
aeneasr,
zepatrik and
piotrmsc
as code owners
August 3, 2023 14:48
aeneasr
requested changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP is so 1995 - please always use HTTPS :)
And follow the rules: https://github.com/ory/docs#placeholders-and-dummy-data
AH right, thanks for keeping an eye out for this! Will see to keep our own styleguide more in mind 😁 |
aeneasr
previously approved these changes
Aug 8, 2023
pls resolve conflicts ty 🙏 |
vinckr
force-pushed
the
flow-oauth2-login
branch
from
August 11, 2023 09:28
b4287d2
to
86eed82
Compare
vinckr
force-pushed
the
flow-oauth2-login
branch
from
August 22, 2023 10:01
86eed82
to
b20dedd
Compare
should be ready now @aeneasr |
aeneasr
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as proposed moves the missing flow steps to the new oauth2 login doc, redirects and deletes the old doc.
closes #1389
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments