Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: batch create identities #1506

Merged
merged 1 commit into from
Aug 21, 2023
Merged

docs: batch create identities #1506

merged 1 commit into from
Aug 21, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Aug 21, 2023

closes #1505

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr requested a review from hperl August 21, 2023 11:47
hperl
hperl approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hperl hperl enabled auto-merge (squash) August 21, 2023 11:49
@hperl hperl mentioned this pull request Aug 21, 2023
Closed
6 tasks
@hperl hperl merged commit 714ffb3 into master Aug 21, 2023
8 checks passed
@hperl hperl deleted the batch-create-identities branch August 21, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hperl hperl hperl approved these changes

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinckr @hperl