Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sidebar migrate guides #1894

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Sep 24, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr
Copy link
Member Author

vinckr commented Sep 24, 2024

I put it at the end of the guides, it did not look right to have it at the very top.
we can find a better place mid-term but now its at least back in the nav ;)

@aeneasr aeneasr merged commit f46c9b9 into master Sep 24, 2024
9 checks passed
@aeneasr aeneasr deleted the vinckr/fix-migrate-to-ory-sidebar branch September 24, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants