Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document ttl for api keys #1899

Merged
merged 8 commits into from
Oct 22, 2024
Merged

feat: document ttl for api keys #1899

merged 8 commits into from
Oct 22, 2024

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Sep 25, 2024

Related Issue or Design Document

https://github.com/ory-corp/cloud/pull/7011

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

vinckr
vinckr previously requested changes Sep 25, 2024
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change, otherwise top :)

docs/concepts/personal-access-token.mdx Outdated Show resolved Hide resolved
docs/concepts/personal-access-token.mdx Outdated Show resolved Hide resolved
…o hperl/workspace-api-key-ttl

# Conflicts:
#	docs/concepts/personal-access-token.mdx
Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related directly to this change but I found a quirk while searching for the updated document in the deployment preview.

You click on Concepts -> APIs (https://docs-cty6n6vwk-ory.vercel.app/docs/api/)
There is a TIP bar that points you to read more about authorization with API Keys (https://docs-cty6n6vwk-ory.vercel.app/docs/concepts/personal-access-token)
You open it and you end in the navigation at Reference -> Operations -> API Keys
Screenshot 2024-10-08 at 08 34 38

Now you go back to docs main page and reference section is different from the one you were previously. We have two reference sections : one in the left hand sidebar and
second on the top nav bar. Now items in left hand does not correlate 1:1 to with items in Reference on the top nav bar. This is quiet confusing.
Screenshot 2024-10-08 at 08 38 56

@vinckr was it something recently added with structure redising?

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hperl hperl merged commit eb17767 into master Oct 22, 2024
8 checks passed
@hperl hperl deleted the hperl/workspace-api-key-ttl branch October 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants