-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document ttl for api keys #1899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change, otherwise top :)
Co-authored-by: Vincent <[email protected]>
Co-authored-by: Vincent <[email protected]>
…o hperl/workspace-api-key-ttl # Conflicts: # docs/concepts/personal-access-token.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related directly to this change but I found a quirk while searching for the updated document in the deployment preview.
You click on Concepts -> APIs (https://docs-cty6n6vwk-ory.vercel.app/docs/api/)
There is a TIP bar that points you to read more about authorization with API Keys (https://docs-cty6n6vwk-ory.vercel.app/docs/concepts/personal-access-token)
You open it and you end in the navigation at Reference -> Operations -> API Keys
Now you go back to docs main page and reference section is different from the one you were previously. We have two reference sections : one in the left hand sidebar and
second on the top nav bar. Now items in left hand does not correlate 1:1 to with items in Reference on the top nav bar. This is quiet confusing.
@vinckr was it something recently added with structure redising?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Related Issue or Design Document
https://github.com/ory-corp/cloud/pull/7011
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments