-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more rop claims #1934
base: master
Are you sure you want to change the base?
feat: more rop claims #1934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally would be better to use active voice instead of passive voice.
so instead of
"The claims in the access token and introspection data can be further customized using a token hook"
"You can customize the claims in the access token and introspection data using a token hook"
Would you agree that the second version is easier to understand?
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments