Skip to content

Conversation

hailam
Copy link

@hailam hailam commented Jun 19, 2025

This PR fixes a minor code redundancy by removing a duplicated assignment in selfservice/hooks/web_hook.go.

Specifically, the line id.VerifiableAddresses = hookResponse.Identity.VerifiableAddresses was being assigned twice, conditional on len(hookResponse.Identity.VerifiableAddresses) > 0. The second, identical block was redundant. Removing it ensures cleaner, more concise code without altering the existing logic or behavior.

This is a non-breaking change and purely a code quality improvement.

Related issue(s)

This is a fix for a previously unknown, minor code redundancy.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This is a small, straightforward code cleanup. No alternatives were considered as the goal was simply to remove the redundant code.

@hailam hailam requested review from aeneasr and a team as code owners June 19, 2025 16:27
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2025

CLA assistant check
All committers have signed the CLA.

@hailam hailam changed the title fix(selfservice/hooks): Remove duplicated verifiable addresses assignment in webhook fix: remove duplicated verifiable addresses assignment in selfservice/hooks/web_hook Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants