fix: remove duplicated verifiable addresses assignment in selfservice/hooks/web_hook #4440
+0
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor code redundancy by removing a duplicated assignment in
selfservice/hooks/web_hook.go
.Specifically, the line
id.VerifiableAddresses = hookResponse.Identity.VerifiableAddresses
was being assigned twice, conditional onlen(hookResponse.Identity.VerifiableAddresses) > 0
. The second, identical block was redundant. Removing it ensures cleaner, more concise code without altering the existing logic or behavior.This is a non-breaking change and purely a code quality improvement.
Related issue(s)
This is a fix for a previously unknown, minor code redundancy.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
This is a small, straightforward code cleanup. No alternatives were considered as the goal was simply to remove the redundant code.