-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unix sockets support for URLs #874
base: master
Are you sure you want to change the base?
feat: add unix sockets support for URLs #874
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
==========================================
+ Coverage 62.47% 62.59% +0.11%
==========================================
Files 102 103 +1
Lines 4813 4895 +82
==========================================
+ Hits 3007 3064 +57
- Misses 1531 1548 +17
- Partials 275 283 +8 ☔ View full report in Codecov by Sentry. |
Thank you, this looks great! It looks like the CLA bot is not properly detecting your signature. To fix this, try the following:
Ensure that
Once that is done, you can force-push your changes (make sure to push to the correct remote and branch!):
|
a7827ee
to
3c8c779
Compare
3c8c779
to
d057b58
Compare
I updated my commits signature and agreed to the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you please include tests and documentation to show case how this feature is configured?
Regarding documentation, do you think I should add a specific section for unix sockets URIs ? |
Porposal for adding unix sockets support for URLs
Related issue(s)
#871
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments