Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unix sockets support for URLs #874

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nlachfr
Copy link

@nlachfr nlachfr commented Nov 4, 2021

Porposal for adding unix sockets support for URLs

Related issue(s)

#871

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@nlachfr nlachfr requested a review from aeneasr as a code owner November 4, 2021 21:48
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021

CLA assistant check
All committers have signed the CLA.

@nlachfr nlachfr closed this Nov 4, 2021
@nlachfr nlachfr changed the title Add the use of unix sockets for URLs Add unix sockets support for URLs Nov 4, 2021
@nlachfr nlachfr reopened this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Attention: Patch coverage is 72.16495% with 27 lines in your changes missing coverage. Please review.

Project coverage is 62.59%. Comparing base (737320f) to head (a557489).
Report is 379 commits behind head on master.

Files with missing lines Patch % Lines
helper/transport.go 78.84% 5 Missing and 6 partials ⚠️
pipeline/authn/authenticator_cookie_session.go 57.69% 10 Missing and 1 partial ⚠️
proxy/proxy.go 44.44% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   62.47%   62.59%   +0.11%     
==========================================
  Files         102      103       +1     
  Lines        4813     4895      +82     
==========================================
+ Hits         3007     3064      +57     
- Misses       1531     1548      +17     
- Partials      275      283       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nlachfr nlachfr marked this pull request as draft November 4, 2021 21:57
@nlachfr nlachfr changed the title Add unix sockets support for URLs feat: add unix sockets support for URLs Nov 4, 2021
@aeneasr
Copy link
Member

aeneasr commented Nov 22, 2021

Thank you, this looks great! It looks like the CLA bot is not properly detecting your signature. To fix this, try the following:

$ git commit  --amend --author="Author Name <[email protected]>"

Ensure that Author Name is replaced with your GitHub username (e.g. aeneasr) and that the email address is replaced with the email address you have set up in GitHub (e.g. [email protected]):

$ git commit  --amend --author="aeneasr <[email protected]>"

Once that is done, you can force-push your changes (make sure to push to the correct remote and branch!):

$ git push --force <remote> HEAD:<branch>

@nlachfr nlachfr force-pushed the feat/unix-socket-support-for-upstreams branch from a7827ee to 3c8c779 Compare November 22, 2021 19:45
@nlachfr nlachfr force-pushed the feat/unix-socket-support-for-upstreams branch from 3c8c779 to d057b58 Compare November 22, 2021 19:54
@nlachfr
Copy link
Author

nlachfr commented Nov 22, 2021

I updated my commits signature and agreed to the CLA

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please include tests and documentation to show case how this feature is configured?

@nlachfr
Copy link
Author

nlachfr commented Dec 2, 2021

Regarding documentation, do you think I should add a specific section for unix sockets URIs ?
For now, I have added a small description on fields able to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants