[codex] Add Vision output overwrite safety#1
Draft
mimeding wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds output overwrite controls to Vision image-writing tools and tests the manifest plus runtime refusal to overwrite existing files by default.
Business Rationale
Vision workflows often produce derived artifacts from user images. Refusing implicit overwrites protects source and output files while still allowing intentional replacement when requested.
Coding Rationale
Overwrite behavior is enforced in the plugin helper that writes image outputs, keeping the safety rule close to the file mutation point. Manifest tests ensure the host and model can see the same output contract.
Expected LLM Performance Improvement
Models should choose explicit output paths, avoid destructive retries, and recover from existing-file conflicts with clear tool feedback instead of silently replacing artifacts.
Changes
Test Plan
swift testswift build -c releasegit diff --check