Clarify remote MCP provider transport support#1058
Draft
mimeding wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business reason
Users were led to believe command-based stdio MCP providers could be added through the remote-provider UI, which creates failed setup paths and unnecessary support churn. This draft makes the supported transport explicit before users save or test a provider.
Coding rationale
The remote-provider path currently uses HTTP/SSE transport only. This change centralizes endpoint validation, rejects non-HTTP endpoints with a specific error, updates the Settings UI copy/validation, and pins the behavior with focused tests.
Draft status
This is intentionally draft because PR #1048 is the green local-CI parent and has not merged yet. The clean diff is based on current
origin/main; focused validation already passed on the stacked #1048 base.Readiness Block
Local CI parity: GAP+blocked by #1048 baseline (commit: 7d1f3c1)
GitHub CI status: PENDING (headRefOid: pending push)
Merge state: PENDING
Known gaps: current
origin/mainstill needs #1048's build/lint stabilization before this can be marked readyReviewer Summary
What this PR adds: Clear HTTP/SSE-only remote MCP provider validation and docs.
What it depends on: #1048 landing first so the local gate baseline is green.
What depends on it: Issue #416 closure evidence.
New public API surface:
MCPProviderManager.validatedHTTPSEndpoint(from:).New tests: 4 focused Swift Testing cases in
MCPProviderEndpointValidationTests.Test corpus: none.
Local gate: GAP on main; PASS when stacked on #1048.
Risk: Low, scoped docs/UI validation and transport guard.
Out of scope: Implementing command-based stdio provider support.