main: add new --use-librepo switch
#786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
changed the title
--use-librepo switch--use-librepo switch
The NewAnacondaContainerInstaller renamed SquashfsCompression to RootfsCompression.
This commit adds a new `--use-librepo` switch that will enable librepo based downloading so that people can play with the new backend. But not turn it on by default yet.
This commit make the use of librepo part of the testcases and enables it for the problematic testcases like fedora and centos-10. Eventually we should switch entirely to librepo but there is a regression risk with secrets so for now make it optional.
Document `--use-librepo` in the README and encourage its usage in the default example. It should be fine for centos and this way we hopefully get more exposure and bugreport (if there are issues).
ondrejbudai
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
--use-libreposwitch that willenable librepo based downloading so that people can play with
the new backend.
Note that --use-librepo defaults to False currently until we have sufficient testing that all cases (including when secrets are required) work.
(with that we can re-enable the fedora iso test-case as it should be no longer flaky and works fine in my local test. however it will increase the test run times again as the isos are pretty "expensive")