-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Add firewall to Review step (HMS-5357) #2769
base: main
Are you sure you want to change the base?
Conversation
Rebased on #2767, so that will need to get merged first. |
/jira-epic HMS-5168 |
cf33a94
to
ee797cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
+ Coverage 83.09% 83.14% +0.05%
==========================================
Files 192 192
Lines 22275 22345 +70
Branches 2178 2190 +12
==========================================
+ Hits 18509 18579 +70
Misses 3744 3744
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
72765ba
to
e8662f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as I am thinking about it, it might be nice to be able to just add a list of services, divided by some kind of separator. 🤔 But I assume this is MVP, and we still need to see if people are using this?:)
<TextListItem component={TextListItemVariants.dd}> | ||
<CodeBlock> | ||
<CodeBlockCode> | ||
{firewall.ports ? firewall.ports.join(' ') : 'None'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this was the intention. 🤔
{firewall.ports ? firewall.ports.join(' ') : 'None'} | |
{firewall.ports.length ? firewall.ports.join(' ') : 'None'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed 😅 updated!
e8662f8
to
4058c49
Compare
4058c49
to
7dd94cd
Compare
Right, the steps are currently going through the UX review as well. cockpit-composer originally took just a string, I wanted to incorporate some kind of validation as well. But might try to address that in a follow up as I see how that might be really nice to have 🤔 maybe we can just split the entire input string and then just work with the items the same way we currently do? |
Oh wait, rebase is needed first 😳 |
This adds a firewall expandable to the Review step.
7dd94cd
to
4231359
Compare
This adds a firewall expandable to the Review step.
JIRA: HMS-5357