Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add inputs for disabled and enabled services (HMS-5403) #2805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 28, 2025

This adds inputs for disabled and enabled systemd services. New tests are also added.

JIRA: HMS-5403

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5371

@schutzbot schutzbot changed the title Wizard: Add inputs for disabled and enabled services Wizard: Add inputs for disabled and enabled services (HMS-5403) Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 89.25620% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (4145157) to head (5dd15e4).

Files with missing lines Patch % Lines
src/store/wizardSlice.ts 74.50% 13 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
+ Coverage   84.55%   84.57%   +0.02%     
==========================================
  Files         190      191       +1     
  Lines       21811    21932     +121     
  Branches     2169     2184      +15     
==========================================
+ Hits        18442    18550     +108     
- Misses       3347     3360      +13     
  Partials       22       22              
Files with missing lines Coverage Δ
...izard/steps/Services/components/ServicesInputs.tsx 100.00% <100.00%> (ø)
...ponents/CreateImageWizard/steps/Services/index.tsx 100.00% <100.00%> (ø)
src/store/wizardSlice.ts 87.06% <74.50%> (-0.79%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4145157...5dd15e4. Read the comment docs.

@regexowl regexowl force-pushed the services-inputs branch 2 times, most recently from cad6e58 to d4e0410 Compare January 28, 2025 13:37
This adds inputs for disabled and enabled systemd services. New tests are also added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant