cockpit: add package search (HMS-5423) #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on @bcl's PR here osbuild/osbuild-composer#4579 |
kingsleyzissou
force-pushed
the
cockpit_store_structure
branch
from
8333c9a to
2e8f2b7
Compare
kingsleyzissou
force-pushed
the
cockpit_store_structure
branch
from
2e8f2b7 to
e51c69c
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 83.08% 82.96% -0.13%
==========================================
Files 192 199 +7
Lines 22324 22395 +71
Branches 2180 2183 +3
==========================================
+ Hits 18549 18581 +32
- Misses 3753 3792 +39
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
kingsleyzissou
force-pushed
the
cockpit_store_structure
branch
2 times, most recently
from
08a2a5b to
68d5ea3
Compare
|
/jira-epic COMPOSER-2411 |
schutzbot
changed the title
croissanne
approved these changes
Feb 3, 2025
croissanne
force-pushed
the
cockpit_store_structure
branch
from
68d5ea3 to
5fd010d
Compare
croissanne
approved these changes
Feb 3, 2025
|
Theoretically we could and probably should, but RTK query really doesn't like it and we get a bunch of weird errors in the console |
|
Ooh IC, yea I think I get it fully now, they both just call the cloudapi after all, makes perfect sense! Interesting that RTK query can tell what's happening under the hood there. |
|
Hm IG because they would use the same basequery? |
Hide the registration step for on-prem frontend
Since we will need to add other api endpoints, e.g. `contentSourcesApi` for the on-prem frontend, this PR restructures the store directory to make future changes more manageable.
This is just a workaround to keep imports to the api definitions the same as before. The added benefit is that we can then use these files to handle the mixed api types between the service frontend and on-prem frontend.
Tidy up the imports and the exports in the `backendApi` mixed api to make things more consistent.
Add a `contentSourcesApi` for the on-prem frontend. We need to add a small workaround and put these endpoints under the `cockpitApi` reducer. since RTK query here, doesn't like splitting out apis when they are fundamentally the same. To workaround this we can will just chain the endpoints so: `emptyCockpitApi` -> `contentSourcesApi` -> `cockpitApi` This allows us to keep the `contentSourcesApi` separate so we can export some of the endpoints so that the `cockpitApi` doesn't become a monolith.
Add initial package search. Include the version, release & arch information in the summary, since some packages might have a release with the specific architecture and a `noarch` version.
croissanne
force-pushed
the
cockpit_store_structure
branch
from
5fd010d to
4a9dacc
Compare
croissanne
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to search for packages in the
CreateImageWizard.This required some more plumbing and some refactoring of the store:
contentSourcesApifor the cockpit frontendbaseQueryfunction to dry up the endpoint callsJIRA: HMS-5423