Wizard: always enable Next, Review, and Create/Save buttons (HMS-10658)#4579
Draft
mgold1234 wants to merge 7 commits into
Draft
Wizard: always enable Next, Review, and Create/Save buttons (HMS-10658)#4579mgold1234 wants to merge 7 commits into
mgold1234 wants to merge 7 commits into
Conversation
mgold1234
force-pushed
the
next_button
branch
8 times, most recently
from
42b9556 to
16a1e92
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4579 +/- ##
==========================================
- Coverage 77.38% 71.19% -6.20%
==========================================
Files 258 257 -1
Lines 6866 6897 +31
Branches 2543 2566 +23
==========================================
- Hits 5313 4910 -403
- Misses 1442 1953 +511
+ Partials 111 34 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 78 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
mgold1234
force-pushed
the
next_button
branch
3 times, most recently
from
2973222 to
a131bcd
Compare
mgold1234
changed the title
mgold1234
force-pushed
the
next_button
branch
5 times, most recently
from
24aeaa6 to
4732560
Compare
Add a ValidationContext that exposes forceShowErrors to force pristine fields to reveal their validation errors. ValidatedInput and TargetEnvironment consume it so errors become visible before the user has interacted with those fields.
Keep Next and Review buttons enabled instead of disabling them when validation fails. On click, force errors visible and scroll to the first error. Extract scrollToFirstError to a shared utility.
…658) Remove isFetching from the registration validation condition so Next is not disabled while the activation key query is in flight. Also return no error when no activation key is selected in hosted mode, since that is a valid initial state.
Add useBlueprintValidation hook that returns isValid and firstErrorStepId, replacing duplicate validation hook calls in the Review footers. Create/Save buttons are always enabled and navigate to the first error step via onBeforeAction when validation fails.
Change toBeDisabled assertions to toBeEnabled for Next and Review buttons across Import, Azure, Registration, and UsersAndGroups specs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Registration and image selection are both on the Base Settings step, so select both before clicking Next. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove the imageTypes.length === 0 check from useBlueprintValidation that was not present in the original useIsBlueprintValid. This check caused the Save button on the Review step to block in cases where the original code allowed it, breaking 21 Playwright tests. Also apply Prettier formatting to CreateImageWizard.tsx. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of disabling Next/Review when validation fails, keep them
enabled and scroll to the first error on click. Create/Save buttons
on the Review step behave the same way — always clickable, but
navigate back to the first error step when validation fails.
A new ValidationContext forces pristine fields to reveal their
errors so the user sees exactly what needs fixing.
JIRA :HMS-10658