Wizard: swap Users and Groups section order (HMS-10791)#4612
Open
mgold1234 wants to merge 1 commit into
Open
Conversation
Show Users before Groups since users are needed almost always while groups are rarely used.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4612 +/- ##
==========================================
- Coverage 77.38% 77.36% -0.02%
==========================================
Files 258 258
Lines 6866 6866
Branches 2543 2493 -50
==========================================
- Hits 5313 5312 -1
- Misses 1442 1443 +1
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The wizard step arrays now duplicate the same
restrictions.users.isStandaloneandrestrictions.users.shouldHide || restrictions.users.isStandalonelogic around reordered Users/Groups; consider extracting this ordering into a small helper or configuration to reduce repetition and make the flow easier to reason about. - In the non-standalone flow, the conditions for
UsersStepandUserGroupsStepare identical; swapping their positions changes order but leaves the logic a bit opaque—renaming or grouping these steps could make the intended ordering clearer to future readers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The wizard step arrays now duplicate the same `restrictions.users.isStandalone` and `restrictions.users.shouldHide || restrictions.users.isStandalone` logic around reordered Users/Groups; consider extracting this ordering into a small helper or configuration to reduce repetition and make the flow easier to reason about.
- In the non-standalone flow, the conditions for `UsersStep` and `UserGroupsStep` are identical; swapping their positions changes order but leaves the logic a bit opaque—renaming or grouping these steps could make the intended ordering clearer to future readers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show Users before Groups since users are needed almost always
while groups are rarely used.
JIRA: HMS-10791