Skip to content

Wizard: swap Users and Groups section order (HMS-10791)#4612

Open
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:group_us
Open

Wizard: swap Users and Groups section order (HMS-10791)#4612
mgold1234 wants to merge 1 commit into
osbuild:mainfrom
mgold1234:group_us

Conversation

@mgold1234

@mgold1234 mgold1234 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Show Users before Groups since users are needed almost always
while groups are rarely used.

JIRA: HMS-10791

  Show Users before Groups since users are needed almost always
  while groups are rarely used.
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (12b6034) to head (bc33c84).
⚠️ Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4612      +/-   ##
==========================================
- Coverage   77.38%   77.36%   -0.02%     
==========================================
  Files         258      258              
  Lines        6866     6866              
  Branches     2543     2493      -50     
==========================================
- Hits         5313     5312       -1     
- Misses       1442     1443       +1     
  Partials      111      111              
Flag Coverage Δ
playwright 60.12% <50.00%> (-0.09%) ⬇️
vitest 71.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 85.18% <100.00%> (ø)
...steps/Review/components/AdvancedSettings/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b6034...bc33c84. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mgold1234 mgold1234 changed the title Wizard: swap Users and Groups section order Wizard: swap Users and Groups section order (HMS-10791) Jul 9, 2026
@mgold1234 mgold1234 marked this pull request as ready for review July 9, 2026 12:58
@mgold1234 mgold1234 requested a review from a team as a code owner July 9, 2026 12:58

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The wizard step arrays now duplicate the same restrictions.users.isStandalone and restrictions.users.shouldHide || restrictions.users.isStandalone logic around reordered Users/Groups; consider extracting this ordering into a small helper or configuration to reduce repetition and make the flow easier to reason about.
  • In the non-standalone flow, the conditions for UsersStep and UserGroupsStep are identical; swapping their positions changes order but leaves the logic a bit opaque—renaming or grouping these steps could make the intended ordering clearer to future readers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The wizard step arrays now duplicate the same `restrictions.users.isStandalone` and `restrictions.users.shouldHide || restrictions.users.isStandalone` logic around reordered Users/Groups; consider extracting this ordering into a small helper or configuration to reduce repetition and make the flow easier to reason about.
- In the non-standalone flow, the conditions for `UsersStep` and `UserGroupsStep` are identical; swapping their positions changes order but leaves the logic a bit opaque—renaming or grouping these steps could make the intended ordering clearer to future readers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant