api: regenerate api code generation#4616
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
kingsleyzissou
approved these changes
Jul 9, 2026
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the common repository fields into a shared type/interface so
version_countand its description don’t need to be repeated across the differentApiRepository*Responsevariants. - With
fedora-45added to theDistributionsunion, review any distribution-specific branching logic (e.g., switch/if chains or mapping objects) to ensure the new value is handled consistently with other Fedora versions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the common repository fields into a shared type/interface so `version_count` and its description don’t need to be repeated across the different `ApiRepository*Response` variants.
- With `fedora-45` added to the `Distributions` union, review any distribution-specific branching logic (e.g., switch/if chains or mapping objects) to ensure the new value is handled consistently with other Fedora versions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This was referenced Jul 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4616 +/- ##
==========================================
- Coverage 77.33% 77.31% -0.02%
==========================================
Files 258 258
Lines 6856 6856
Branches 2490 2540 +50
==========================================
- Hits 5302 5301 -1
- Misses 1443 1444 +1
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
croissanne
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update api code generation