Skip to content

Commit

Permalink
rhel10: drop ifcfg-eth0 sysconfig network-scripts file
Browse files Browse the repository at this point in the history
The AMI for rhel9 and below writes a `ifcfg-eth0` sysconfig file
that enables dhcp and disables ipv6. This commit drops this
file because:
1. ipcfg-rh is deprecated
2. NetworkManager defaults to dhcp by default for wired ethernet
   (unless configured otherwise)
3. It seems we do not need to disable ipv6 in 2024 anymore

With the exception of (3) I'm pretty confident in this commit.
Feedback welcome.
  • Loading branch information
mvo5 authored and ondrejbudai committed Aug 6, 2024
1 parent 367507a commit fa9b520
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions pkg/distro/rhel/rhel10/ami.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,6 @@ func baseEc2ImageConfig() *distro.ImageConfig {
Networking: true,
NoZeroConf: true,
},
NetworkScripts: &osbuild.NetworkScriptsOptions{
IfcfgFiles: map[string]osbuild.IfcfgFile{
"eth0": {
Device: "eth0",
Bootproto: osbuild.IfcfgBootprotoDHCP,
OnBoot: common.ToPtr(true),
Type: osbuild.IfcfgTypeEthernet,
UserCtl: common.ToPtr(true),
PeerDNS: common.ToPtr(true),
IPv6Init: common.ToPtr(false),
},
},
},
},
},
SystemdLogind: []*osbuild.SystemdLogindStageOptions{
Expand Down

0 comments on commit fa9b520

Please sign in to comment.