many: use new disk.PartitionTableType instead of string
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
reviewed
Nov 7, 2024
mvo5
force-pushed
the
use-new-partiton-table-type
branch
from
2654d8c to
7086d75
Compare
thozza
reviewed
Nov 8, 2024
This commit adds json marshal/unmarshal to `PartitionTableType`
The reason is that the `otk` utils serialize this type
as a JSON. While the json is strictly internal and we make no
gurantees about it is still nicer to serialize as strings because
otherwise the diff in the json looks something like:
```json
@@ -147,7 +147,7 @@ func TestUnmarshalOutput(t *testing.T) {
"partition-table": {
"Size": 911,
"UUID": "",
- "Type": "gpt",
+ "Type": 2,
"Partitions": [
{
"Start": 0,
```
and it is also nicer for general debug-ability.
This commit makes use of the new `disk.PartitionTableType instead of just using an untyped string (thanks to Achilleas for adding the new type and to Tomáš for suggesting to use it more).
mvo5
force-pushed
the
use-new-partiton-table-type
branch
from
7086d75 to
16564da
Compare
achilleas-k
approved these changes
Nov 8, 2024
|
Also, can you update the top PR comment/description to avoid confusion in the future? |
Yeah, I guess we want this for |
Fine to do in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes use of the new `disk.PartitionTableType instead of just using an untyped string (thanks to Achilleas for adding the new type and to Tomáš for suggesting to use it more).
disk: add json marshal/unmarshal to
PartitionTableTypeThis commit adds json marshal/unmarshal to
PartitionTableTypeThe reason is that the
otkutils serialize this typeas a JSON. While the json is strictly internal and we make no
gurantees about it is still nicer to serialize as strings because
otherwise the diff in the json looks something like:
and it is also nicer for general debug-ability.