Validate OSTree options on RHEL10 #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check seems to have been lost in the initial commit of this file. Discovered while working on weldr-client tests running on RHEL10. Related: RHEL-67056
|
There may be other things missing from this file, it looks quite a bit different from the fedora and rhel9 versions but I can't tell what supposed to be there and what isn't -- other than this, which was caught by my weldr-client tests when I run it on RHEL10. |
|
We're not supporting edge for RHEL 10, so it might be more appropriate for this check to return an error when |
|
I went ahead and implemented the check for all distros in #1071 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check seems to have been lost in the initial commit of this file. Discovered while working on weldr-client tests running on RHEL10.
Related: RHEL-67056