Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run gitlab CI build jobs on Fedora 41 #1058

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Run gitlab CI build jobs on Fedora 41 #1058

merged 5 commits into from
Jan 3, 2025

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Nov 22, 2024 •
edited
Loading

Schutzfile: switch Fedora 41 repos to released

Schutzfile: define common gitlab-ci-runner

imgtestlib: read common CI runner from Schutzfile

Use the common CI runner defined in the Schutzfile in all gitlab CI
generators.

gitlab: bump gitlab CI runners to Fedora 41

schutzbot: update terraform commit ID

thozza
thozza previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the 🧹

I've added one idea, but don't consider it a blocker.

test/scripts/imgtestlib.py Outdated Show resolved Hide resolved
@achilleas-k
Copy link
Member Author

Added the CI runner definition to the Schutzfile and updated the terraform SHA to the newest which includes Fedora 41 runner definitions.

thozza
thozza previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 😍

@achilleas-k
Copy link
Member Author

achilleas-k commented Nov 26, 2024 •
edited
Loading

A lot of jobs timed out in GitLab. I'm hoping it's because this PR was running at the same time as #1066, both of which caused a rebuild of every test image (this one because the runner changed and the other because the osbuild commit ID changed).

I hit the rebase button here now, which means a full rebuild again, but it also means we wont need one on the merge queue.

@achilleas-k achilleas-k force-pushed the ci/runners/f41 branch 2 times, most recently from f272a83 to 732ecee Compare November 28, 2024 11:01
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 29, 2024
@thozza thozza removed the Stale label Dec 30, 2024
@thozza
Copy link
Member

thozza commented Dec 31, 2024

@achilleas-k try using the latest main HEAD from terraform repo. I updated the F41 AMIs osbuild/gitlab-ci-terraform#176

@achilleas-k
Copy link
Member Author

@achilleas-k try using the latest main HEAD from terraform repo. I updated the F41 AMIs osbuild/gitlab-ci-terraform#176

Rebased, resolved conflicts, and updated the commit ID.

Thanks!!

@thozza thozza added this pull request to the merge queue Jan 3, 2025
Merged via the queue into osbuild:main with commit 7b0a9f9 Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thozza thozza thozza approved these changes

@mvo5 mvo5 Awaiting requested review from mvo5

@supakeen supakeen Awaiting requested review from supakeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achilleas-k @thozza