Test/scripts: move shared code to imgtestlib (HMS-5242)
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the function to the `imgtestlib`, so that it can be later shared among multiple scripts. The intention is to use it later in a script to generate the "image-info" report. Signed-off-by: Tomáš Hozza <[email protected]>
Move the function to the `imgtestlib`, so that it can be later shared among multiple scripts. The intention is to use it later in a script to generate the "image-info" report. Signed-off-by: Tomáš Hozza <[email protected]>
Also add doc string. Signed-off-by: Tomáš Hozza <[email protected]>
Add a new helper function `write_build_info()` to imgtestlib, to ensure consistent way to write the build `info.json` and de-duplicate code. Modify all remaining places which read / write `info.json` to use functions from imgtestlib. Signed-off-by: Tomáš Hozza <[email protected]>
schutzbot
changed the title
imgtestlibimgtestlib (HMS-5242)
supakeen
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_image_file()from boot-image toimgtestlibso that a new script generating the image-info report can use it later.{read,write}_build_info()functions inimgtestlibto read/write buildinfo.jsonand use them everywhere./jira-epic COMPOSER-2318
JIRA: HMS-5242