osbuild: add org.osbuild.librepo source wrapper #1141
Conversation
pkg/osbuild/librepo_source.go
Outdated
| Items map[string]*librepoSourceItem `json:"items"` | ||
| Options *librepoSourceOptions `json:"options"` |
There was a problem hiding this comment.
I'd prefer we make the types exported/public so that one can, if they want, create a LibrepoSource{} without functions or helpers. It's not the preferred way to do it, but I think pkg/osbuild/ should support that workflow generally.
There was a problem hiding this comment.
I can change them back to exported (there were in my first version), I changed them because it easy to create non-working osbuild.LibrepoSources when doing this by hand, the repos and package IDs must match etc so this is meant as a hint "use-the-helper". But fine to change them as the rest of the package exports all types (I guess consistency here is more important than my whims)
There was a problem hiding this comment.
I changed it back to export everything. I would love to reduce our API surface though longer-term but not a discussion we need for this PR :)
mvo5
force-pushed
the
osbuild/add-librepo-wrapper
branch
2 times, most recently
from
03e8b44 to
a8bfc92
Compare
This commit adds a wrapper for the org.osbuild.librepo source to download RPMs.
mvo5
force-pushed
the
osbuild/add-librepo-wrapper
branch
from
a8bfc92 to
e0aeb90
Compare
This commit adds a wrapper for the org.osbuild.librepo source
to download RPMs.
Note that this does not allow customizing the librepo options
MaxParallels, FastestMirror yet. We need to brainstorm this
a bit. The reason is that GenSources() does not currently allow
much control so our (library) users cannot customize it easily.
Split out/cleaned up version of #1132