Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro: conditionally include basesystem/filesystem #1202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miabbott
Copy link

@miabbott miabbott commented Feb 7, 2025

The basesystem package is being obsoleted by filesystem in Rawhide (F43). Change the definition of the iot-commit to conditionally include the correct package based on the Fedora version.

@miabbott miabbott requested a review from a team as a code owner February 7, 2025 18:19
The `basesystem` package is being obsoleted by `filesystem` in Rawhide
(F43). Change the definition of the `iot-commit` to conditionally
include the correct package based on the Fedora version.

Signed-off-by: Micah Abbott <[email protected]>
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I saw the discussion ongoing; let's fix it here. Personally I'd structure this with an else instead of two separate conditionals but not a blocker.

@miabbott
Copy link
Author

miabbott commented Feb 7, 2025

Yea, I saw the discussion ongoing; let's fix it here. Personally I'd structure this with an else instead of two separate conditionals but not a blocker.

That was my first thought, too, but I didn't see any examples of using an else, so I thought there was some prior style that should be maintained.

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants