Set the chunk size for S3 upload to 64MB #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default minimum chunk size of 5MB for s3 upload only allows for an upload of about 50Gi. It is not out of the question for a bootc image to get above this threshhold. For now, this will increase the chunk size to 64MB making it possible to upload images up to ~640Gi. This could in the future become a dynamic value, but for now, this should at least give some head room. Signed-off-by: Brad P. Crochet <[email protected]>
bcrochet
force-pushed
the
add-chunk-size-override
branch
from
75a7a42 to
23d7644
Compare
Thanks. Failed checks appear to be unrelated? |
|
There's a small chance the PR might fail in the merge queue because of some flaky testing that started happening recently. If it does, then #725 should fix it, so I'll re-queue it after that's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default minimum chunk size of 5MB for s3 upload only allows for an upload of about 50Gi. It is not out of the question for a bootc image to get above this threshhold.
For now, this will increase the chunk size to 64MB making it possible to upload images up to ~640Gi. This could in the future become a dynamic value, but for now, this should at least give some head room.