This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
Generate manifests on c10s and RHEL-10.0-nightly (COMPOSER-2161) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osbuild-composer repo is no longer used as the source of image definitions. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
thozza
changed the title
thozza
force-pushed
the
add-el10-c10s
branch
3 times, most recently
from
8fba76b to
d707131
Compare
Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
It is not really needed for anything. In addition, it is also not available for c10s / el10 and therefore makes the script to fail. Signed-off-by: Tomáš Hozza <[email protected]>
Hard fail when there are no test manifests for the given distro and arch make it unnecessarily complicated to enable new distro and generate manifests for them (it would have to be done in two steps). There is IMHO really no good reason to hard fail if there are no test manifests for the selected distro and arch. Print a warning and exit gracefully. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
requested review from
atodorov,
lucasgarfield,
ondrejbudai,
achilleas-k and
schuellerf
and removed request for
lucasgarfield
Merged
atodorov
approved these changes
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA