Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix api.sh gcp ssh connection timeout #4348

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jrusz
Copy link
Contributor

@jrusz jrusz commented Sep 5, 2024

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@jrusz jrusz force-pushed the fix-gcp-timeout branch 5 times, most recently from 9ccc058 to 84a7df4 Compare September 10, 2024 06:01
@bcl
Copy link
Contributor

bcl commented Sep 10, 2024

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

@jrusz jrusz force-pushed the fix-gcp-timeout branch 3 times, most recently from 43294dd to a60d10d Compare September 12, 2024 09:00
@jrusz jrusz changed the title Fix gcp timeout tests: fix api.sh gcp ssh connection timeout Sep 12, 2024
@jrusz jrusz marked this pull request as ready for review September 12, 2024 09:01
@jrusz
Copy link
Contributor Author

jrusz commented Sep 12, 2024

Can you just pass it after the --? Otherwise I think you need to escape the "s in order to get them to pass to the command instead of being evaluated by bash.

I've been trying different variations over the week while working on other stuff and I've finally found something that seems to work 😅

@jrusz jrusz marked this pull request as draft September 12, 2024 11:13
@jrusz
Copy link
Contributor Author

jrusz commented Sep 12, 2024

Unfortunately it looks like it doesn't help resolve our issue https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7807093869
I'm going to try something else.

@jrusz jrusz force-pushed the fix-gcp-timeout branch 3 times, most recently from 39ce4c4 to 44d30d7 Compare September 12, 2024 13:53
@jrusz jrusz marked this pull request as ready for review September 12, 2024 13:54
@jrusz
Copy link
Contributor Author

jrusz commented Sep 12, 2024

I was unable to come into agreement with the gcloud command so I've decided to implement our own retry mechanism which worked when I tested it on the side, I hope other tests are fine with it as well. Here is where it helped prevent the timeout https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/7809695856

@jrusz jrusz requested review from thozza and bcl September 13, 2024 10:01
Fixing this by implementing a retry for the whole ssh connection
attempt.
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ❤️

@jrusz jrusz merged commit f58193d into osbuild:main Sep 16, 2024
44 of 50 checks passed
@jrusz jrusz deleted the fix-gcp-timeout branch September 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants