Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: update images Manifest() API for PR#1107 #4539

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Dec 20, 2024

This updates composer to use the updated API in images around the seed handling for manifests, see images PR#1107 for details.

Note that this has no semantic changes yet. We could now simplfy some things because images will auto-seed but that is for a followup.

@mvo5 mvo5 force-pushed the images-pr1107 branch 2 times, most recently from 741e309 to 40317ee Compare January 10, 2025 15:01
@mvo5 mvo5 marked this pull request as ready for review January 10, 2025 15:02
@mvo5 mvo5 requested a review from thozza January 10, 2025 15:02
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. I'd happily approve the PR once you fix all the test/lint failures.

@mvo5
Copy link
Contributor Author

mvo5 commented Jan 13, 2025

Thanks for submitting this. I'd happily approve the PR once you fix all the test/lint failures.

Ups, my bad - I missed the errors over the rpm build failures (that seem unrelated?). Hopefully I caught them all now.

This commit updates the "images" dependency.
This updates composer to use the updated API in images around the
seed handling for manifests, see images PR#1107 for details.

Note that this has no semantic changes yet. We could now simplfy
some things because images will auto-seed but that is for a followup.
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@thozza thozza enabled auto-merge (rebase) January 14, 2025 08:48
@thozza thozza merged commit af0543d into osbuild:main Jan 20, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants