docs: updates triager role to reviewer role in contributor ladder #70
Conversation
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
jpower432
requested review from
jflowers,
degenaro,
yuji-watanabe-jp,
mrgadgil,
ancatri and
vikas-agarwal76
MEMBERSHIP.md
Outdated
|
|
||
| * You have the permission to approve, but not merge, a PR. |
There was a problem hiding this comment.
Can reviewer not merge a PR? Above in the permissions for Reviewer it is mentioned that they have write access with merging restricted via CODEOWNERS.
There was a problem hiding this comment.
@vikas-agarwal76 I think this could be reworded, but the reviewer could merge a PR (they would have write access), it would just need a maintainer approval first if "Require review from Code Owners" is set as a branch protection rule. Does this clarify? If so, I can alter the sections pertaining to this.
There was a problem hiding this comment.
I refined the section to be more explicit about what would be restricted through CODEOWNERS
MEMBERSHIP.md
Outdated
|
|
||
| Triagers are active contributors in the community through issue and pull request triage. Triagers are expected to remain active in this task. | ||
| Reviewers are knowledgeable about both the codebase and are able review code for quality and correctness. They should expect issues and pull requests (PRs) to be assigned to them and respond per community expectations. |
| @@ -105,7 +120,7 @@ As a project Maintainer, you have the following responsibilities and privileges: | |||
| * You make and approve technical design decisions. | |||
| * You set technical direction and priorities. | |||
| * You define milestones and releases. | |||
| * You mentor and guide contributors to the project, including mentoring and sponsoring potential Triager and Maintainer candidates. | |||
| * You mentor and guide contributors to the project, including mentoring and sponsoring potential Reviewer and Maintainer candidates. | |||
There was a problem hiding this comment.
Reviewer mentors Maintainer candidates?
There was a problem hiding this comment.
This is listed as a Maintainer responsibility. Existing maintainers mentor reviewer and maintainer candidates.
Signed-off-by: Jennifer Power <[email protected]>
We want maintainer approval to merge PRs, but not restrict the ability to merge PRs with the proper approvals Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
|
Looks like this change is approved. I propose that we demonstrate this in |
What Changed?
Per feedback during GitHub Teams structure review with
compliance-trestle:triagerwithreviewerRationale
The Triager role has the responsibility of reviewing PR and issues without access to the source repository.
A specific issue cited here from GitHub Docs:
If a collaborator with admin, owner, or write access to the repository submits a review requesting changes, the pull request cannot be merged until the same collaborator submits another review approving the changes in the pull request.A triager would not have blocking feedback and cannot merge PRs that are fully approved.