Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make test fails in trestle development environment when there is a pre-exisiting trestle workspace in /tmp #1525

Open
degenaro opened this issue Feb 27, 2024 · 2 comments · May be fixed by #1637
Open

make test fails in trestle development environment when there is a pre-exisiting trestle workspace in /tmp #1525

degenaro opened this issue Feb 27, 2024 · 2 comments · May be fixed by #1637
Assignees
@a-memesh
Labels
Backlog bug Something isn't working

Comments

@degenaro
Copy link
Collaborator

Describe the bug

During trestle development, if there is a pre-existing workspace in /tmp when make test is run several tests will fail. The quick fix is to remove the trestle workspace from /tmp.

In the longer term, the tests should not rely upon a pristine /tmp folder, e.g. one without an existing trestle workspace.

To Reproduce

Steps to reproduce the behavior:

  1. create trestle development environment, comprising python venv and download of trestle develop branch.
  2. use trestle init to create trestle workspace in the /tmp folder
  3. run make test in the downloaded trestle devlop branch
  4. See errors

Expected behavior

The errors should not occur, regardless of the presence of a trestle workspace in /tmp

Screenshots / Logs.

N/A

Environment

  • OS: RHEL 8
  • Python version: 3.10
  • Installed packages: trestle develop branch
@jpower432 jpower432 added the bug Something isn't working label May 31, 2024
@jpower432 jpower432 added this to the v3.1.0 milestone May 31, 2024
@jpower432 jpower432 modified the milestones: v3.1.0, v3.2.0, v3.3.0 Jun 13, 2024
@AleJo2995 AleJo2995 removed this from the v3.3.0 milestone Jun 28, 2024
@a-memesh
Copy link

a-memesh commented Jul 2, 2024

Hey @degenaro, I wasn't able to reproduce the error. Here's what I did:

  • Activated the virtual environment (called venv.trestle as shown in the screenshot), which is located outside the root compliance-trestle directory
  • Made a folder and called it tmp while on the root directory
  • Ran cd tmp to cd into the folder
  • Ran trestle init to initiate a trestle workspace
  • Ran cd .. to go back to the root directory
  • Ran make test

According to the issue description, I'm supposed to get errors, but I only got a warning. Here's a screenshot:

image

@degenaro
Copy link
Collaborator Author

degenaro commented Jul 8, 2024

You did this?

use trestle init to create trestle workspace in the /tmp folder

That is, the absolute path to /tmp.

cd /tmp
trestle init

Your don't need to create a tmp folder. You need to do a trestle init in your user's existing root /tmp folder to cause this problem.

@a-memesh a-memesh mentioned this issue Jul 23, 2024
Closed
11 tasks
@a-memesh a-memesh linked a pull request Jul 23, 2024 that will close this issue
fix: add a pytest fixture to prevent make test error #1636
Closed
11 tasks
@a-memesh a-memesh linked a pull request Jul 29, 2024 that will close this issue
Open
11 tasks
@a-memesh a-memesh removed a link to a pull request Jul 30, 2024
fix: add a pytest fixture to prevent make test error #1636
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-memesh a-memesh

Labels
Backlog bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add a pytest fixture to prevent make test error oscal-compass/compliance-trestle
4 participants
@degenaro @AleJo2995 @jpower432 @a-memesh