Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a pytest fixture to prevent make test error #1637

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

a-memesh
Copy link

@a-memesh a-memesh commented Jul 29, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Fixes #1525

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@a-memesh a-memesh requested a review from degenaro July 29, 2024 21:38
Copy link
Collaborator

@degenaro degenaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start. I'm not sure trestle test suite should be using the /tmp folder as the root folder for trestle init. Is it possible to have test suite use, say, /tmp/trestle-test.workspace (or similar) as the root folder? The clean-up of just that folder would be less dangerous, IMO.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test fails in trestle development environment when there is a pre-exisiting trestle workspace in /tmp
2 participants