Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add example csv for multiple rules and checks #1745

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: add example csv for multiple rules and checks #1745

wants to merge 4 commits into from

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Nov 6, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro degenaro added documentation Improvements or additions to documentation transforms Relates to a format transformation or extrapolation demos labels Nov 6, 2024
@degenaro degenaro mentioned this pull request Nov 6, 2024
Closed
11 tasks
vikas-agarwal76
vikas-agarwal76 requested changes Nov 6, 2024
View reviewed changes
docs/tutorials/Transformers_and_Tasks/csv_to_oscal_cd.md Outdated

2. Multiple checks per rule and multiple target-components per rule: [rule-name-overlap.csv](csv_to_oscal_cd/rule-name-overlap.csv)

This example shows how to specify multiple rules per control and multiple checks per rule.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows multiple checks per rule and multiple target components have same rule id.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And csv file had a small mix-up too. Fixed.

@degenaro degenaro self-assigned this Nov 6, 2024
@degenaro degenaro added this to the v3.6.0 milestone Nov 6, 2024
@degenaro
fix csv and markdown text
04dbd1b 
Signed-off-by: Lou DeGenaro <[email protected]>
vikas-agarwal76
vikas-agarwal76 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

butler54
butler54 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

@butler54 butler54 butler54 approved these changes

@AleJo2995 AleJo2995 Awaiting requested review from AleJo2995

@jpower432 jpower432 Awaiting requested review from jpower432

Assignees

@degenaro degenaro

Labels
demos documentation Improvements or additions to documentation transforms Relates to a format transformation or extrapolation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@degenaro @butler54 @vikas-agarwal76