Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Remove the parameter align from the populate_area function.#57

Closed
Ticonderoga2017 wants to merge 1 commit intooscomp:mainfrom
Ticonderoga2017:huge_page
Closed

Remove the parameter align from the populate_area function.#57
Ticonderoga2017 wants to merge 1 commit intooscomp:mainfrom
Ticonderoga2017:huge_page

Conversation

@Ticonderoga2017
Copy link
Copy Markdown

Description

Related Issues(If necessary)

Implementation Details

How to Test

Tips: Please provide the test results of running testcases for starry-next on the commit corresponding to your PR. You can paste it here in the form of a screenshot, or provide a CI link to a branch or fork of starry-next for us to review.

Additional Notes

@Azure-stars
Copy link
Copy Markdown
Collaborator

remove the final unused branch because it will not be entered

match page_size {
PageSize::Size4K => PageIter4K::<VirtAddr>::new(start, end).map(Self::Size4K),
PageSize::Size2M => PageIter2M::<VirtAddr>::new(start, end).map(Self::Size2M),
PageSize::Size1G => PageIter1G::<VirtAddr>::new(start, end).map(Self::Size1G),
_ => None,
}

@Azure-stars
Copy link
Copy Markdown
Collaborator

And please move https://github.com/oscomp/arceos/blob/main/modules/axmm/src/backend/page_iter_wrapper.rs to the axmm/src directory. It should not be put under backend.

@Azure-stars Azure-stars mentioned this pull request Jun 15, 2025
@Azure-stars
Copy link
Copy Markdown
Collaborator

Finish it in #50.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants