Use protocol level prepare instead of PREPARE sql commands #2276
+61
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new pg_conn_t::prepare() function which is now used in several places instead of pg_conn_t::exec() with a SQL PREPARE command. This does not yet replace all places where PREPARE is used, the rest will come in a later commit. This is to make osm2pgsql work with some connection poolers that have problems with prepared statements. For some background see osm2pgsql-dev#2118 and https://www.crunchydata.com/blog/prepared-statements-in-transaction-mode-for-pgbouncer
joto
force-pushed
the
protocol-level-prepare
branch
from
e15ecee to
f4ace45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new pg_conn_t::prepare() function which is now used in several places instead of pg_conn_t::exec() with a SQL PREPARE command.
This does not yet replace all places where PREPARE is used, the rest will come in a later commit.
This is to make osm2pgsql work with some connection poolers that have problems with prepared statements. For some background see #2118 and https://www.crunchydata.com/blog/prepared-statements-in-transaction-mode-for-pgbouncer