Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crowdpunk dao token #1410

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

sirnicolaz
Copy link
Contributor

Description

Adding CROWDP token, an ERC20 IBC coin from chain EVMOS.

CROWDP is the token of Crowdpunk DAO, legally recognized as Crowdpunk DAO OÜ. Some information:

Adding pairs:

  • CROWDP/OSMO
  • CROWDP/USDC

Checklist

Adding Assets

If adding a new asset, please ensure the following:

On-chain liquidity

For each new asset, please provide the plan for on-chain liquidity of the asset:

CROWDP/OSMO

CROWDP/USDC

@sunnya97 sunnya97 marked this pull request as ready for review April 20, 2024 20:10
@sunnya97
Copy link
Contributor

Please fix the merge conflicts

@JeremyParish69 JeremyParish69 merged commit d1db844 into osmosis-labs:main Apr 22, 2024
6 checks passed
@JeremyParish69
Copy link
Collaborator

I'm not seeing this asset at https://app.evmos.org/assets
Is it going to be added there?

@sirnicolaz
Copy link
Contributor Author

I'm not seeing this asset at https://app.evmos.org/assets Is it going to be added there?

We are still waiting for them to integrate it, they said they are in the process. Should I comment here once that's done or open a new PR @JeremyParish69 ?

@JeremyParish69
Copy link
Collaborator

I'm not seeing this asset at https://app.evmos.org/assets Is it going to be added there?

We are still waiting for them to integrate it, they said they are in the process. Should I comment here once that's done or open a new PR @JeremyParish69 ?

Either will work. If you comment here, I will be able to create a new PR that sets the asset to being listed.

@forbesus
Copy link

Hello @JeremyParish69
CROWDP token was listed on evmos

Could you please put crowdp on the list?

@JeremyParish69
Copy link
Collaborator

Hello @JeremyParish69 CROWDP token was listed on evmos

Could you please put crowdp on the list?

Sure, will do.

Note that this asset will be listed on Osmosis Zone as an Unverified asset. If this asset should be upgraded to Verified status, please create another Pull Request to this repository to upgrade it (after reviewing the qualification criteria and requirements).
https://github.com/osmosis-labs/assetlists/blob/main/LISTING.md#upgrade-asset-to-verified-status-permissioned

@forbesus
Copy link

Thank you @JeremyParish69
But crowdp was listed on cosmostation with demon ibc/5EC896BED3EBCB2CB6F1C167582E4EFA3F6FA3385F28BA5EA92D4A489DA010C5

https://github.com/cosmostation/chainlist/blob/c8f3c60726844d1ed8fd9ff6cb1535b6e869a364/chain/osmosis/assets.json#L3389

In osmosis, crowdp is showing wrong denom ibc/DEE262653B9DE39BCEF0493D47E0DFC4FE62F7F046CF38B9FDEFEBE98D149A71
image

Would you also check this?

@forbesus
Copy link

And cosmostation team is not using assets.json file anymore
Now they are using assets_2.json file now

https://github.com/cosmostation/chainlist/blob/ce83649df70327056f3375ed8e91d5eb8c50872a/chain/osmosis/assets_2.json#L7351

Thank you

@JeremyParish69
Copy link
Collaborator

Thank you @JeremyParish69 But crowdp was listed on cosmostation with demon ibc/5EC896BED3EBCB2CB6F1C167582E4EFA3F6FA3385F28BA5EA92D4A489DA010C5

https://github.com/cosmostation/chainlist/blob/c8f3c60726844d1ed8fd9ff6cb1535b6e869a364/chain/osmosis/assets.json#L3389

In osmosis, crowdp is showing wrong denom ibc/DEE262653B9DE39BCEF0493D47E0DFC4FE62F7F046CF38B9FDEFEBE98D149A71 image

Would you also check this?

Your screenshot is of the NEOK asset page, not the CROWDP asset page. I don't there is any error.

@JeremyParish69
Copy link
Collaborator

And cosmostation team is not using assets.json file anymore Now they are using assets_2.json file now

https://github.com/cosmostation/chainlist/blob/ce83649df70327056f3375ed8e91d5eb8c50872a/chain/osmosis/assets_2.json#L7351

Thank you

Something is very wrong; the change from you looks incorrect and has to be reset

@JeremyParish69
Copy link
Collaborator

JeremyParish69 commented Nov 22, 2024

After further investigation, it looks like the replacement ibc hash (that I see from your PR to Cosmostation) is what it would be when replacing the contract from all lowercase to 0xfbF4318d24a93753F11d365A6dcF8b830e98Ab0F (with this specific set of uppercase characters). If this is the correct address, it should be corrected at the Cosmos Chain Registry. If not corrected at the Chain Registry, Cosmostation's repo will eventually be reset back automatically to what it was before, undoing your change.

@forbesus
Copy link

forbesus commented Nov 22, 2024

Thank you @JeremyParish69 But crowdp was listed on cosmostation with demon ibc/5EC896BED3EBCB2CB6F1C167582E4EFA3F6FA3385F28BA5EA92D4A489DA010C5
https://github.com/cosmostation/chainlist/blob/c8f3c60726844d1ed8fd9ff6cb1535b6e869a364/chain/osmosis/assets.json#L3389
In osmosis, crowdp is showing wrong denom ibc/DEE262653B9DE39BCEF0493D47E0DFC4FE62F7F046CF38B9FDEFEBE98D149A71 image
Would you also check this?

Your screenshot is of the NEOK asset page, not the CROWDP asset page. I don't there is any error.

I am sorry
image
Here is crowdp screenshot
ibc/B87F0F5255CC658408F167C2F7B987A8D914622E1F73BCC267406360588F2B1E

@JeremyParish69
Copy link
Collaborator

I am sorry image Here is crowdp screenshot ibc/B87F0F5255CC658408F167C2F7B987A8D914622E1F73BCC267406360588F2B1E

So this IBC hash denom is correct based on the registered contract. If this is incorrect, then the registration must be corrected as well.

@forbesus
Copy link

Okay, I am creating PR again

cosmos/chain-registry#5617

Would you check this? @JeremyParish69

@JeremyParish69
Copy link
Collaborator

Okay, I am creating PR again

cosmos/chain-registry#5617

Would you check this? @JeremyParish69

Thanks, it's been merged now. After updating the Osmosis Zone assetlist, I can see that at least 1 pool has been detected, so the updated contract seems to be confirmed. Osmosis Zone should reflect the update shortly

@forbesus
Copy link

Thank you @JeremyParish69
I think you will need #2080
How about you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants