Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE-586 | OrderBookClient use slices.Split for pagination #533

Closed
wants to merge 1 commit into from
Closed

BE-586 | OrderBookClient use slices.Split for pagination #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions domain/orderbook/grpcclient/orderbook_grpc_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

cosmwasmdomain "github.com/osmosis-labs/sqs/domain/cosmwasm"
orderbookdomain "github.com/osmosis-labs/sqs/domain/orderbook"
"github.com/osmosis-labs/sqs/domain/slices"

wasmtypes "github.com/CosmWasm/wasmd/x/wasm/types"
)
Expand Down Expand Up @@ -88,19 +89,11 @@ func (o *orderbookClientImpl) GetTickUnrealizedCancels(ctx context.Context, cont
func (o *orderbookClientImpl) FetchTickUnrealizedCancels(ctx context.Context, chunkSize int, contractAddress string, tickIDs []int64) ([]UnrealizedTickCancels, error) {
allUnrealizedCancels := make([]UnrealizedTickCancels, 0, len(tickIDs))

for i := 0; i < len(tickIDs); i += chunkSize {
end := i + chunkSize
if end > len(tickIDs) {
end = len(tickIDs)
}

currentTickIDs := tickIDs[i:end]

unrealizedCancels, err := o.GetTickUnrealizedCancels(ctx, contractAddress, currentTickIDs)
for _, chunk := range slices.Split(tickIDs, chunkSize) {
unrealizedCancels, err := o.GetTickUnrealizedCancels(ctx, contractAddress, chunk)
if err != nil {
return nil, fmt.Errorf("failed to fetch unrealized cancels for ticks %v: %w", currentTickIDs, err)
return nil, fmt.Errorf("failed to fetch unrealized cancels for ticks %v: %w", chunk, err)
}

allUnrealizedCancels = append(allUnrealizedCancels, unrealizedCancels...)
}

Expand All @@ -124,15 +117,8 @@ func (o *orderbookClientImpl) QueryTicks(ctx context.Context, contractAddress st
func (o *orderbookClientImpl) FetchTicks(ctx context.Context, chunkSize int, contractAddress string, tickIDs []int64) ([]orderbookdomain.Tick, error) {
finalTickStates := make([]orderbookdomain.Tick, 0, len(tickIDs))

for i := 0; i < len(tickIDs); i += chunkSize {
end := i + chunkSize
if end > len(tickIDs) {
end = len(tickIDs)
}

currentTickIDs := tickIDs[i:end]

tickStates, err := o.QueryTicks(ctx, contractAddress, currentTickIDs)
for _, chunk := range slices.Split(tickIDs, chunkSize) {
tickStates, err := o.QueryTicks(ctx, contractAddress, chunk)
if err != nil {
return nil, fmt.Errorf("failed to fetch ticks for pool %s: %w", contractAddress, err)
}
Expand Down
Loading