BE-696 | Feature request to improve service recovery after restart #624
Conversation
This PR enables to start SQS service without early exit when Node is not available. New behaviour is controlled with configuration variable to avoid discrepancies for the current setup with a defaults for early exit. Feature can be tested with following command: ```bash SQS_SKIP_CHAIN_AVAILABILITY_CHECK=true go run app/*.go ```
|
WalkthroughThe changes improve error handling and configuration in the application. The error handling in the main function now conditionally logs errors from the blockchain client based on a configuration flag, instead of always panicking. Similarly, the sidecar query server now logs errors from the gRPC gateway status check. In addition, a new configuration field has been introduced to allow skipping the chain availability check. Changes
Sequence Diagram(s)sequenceDiagram
participant Main
participant ChainClient
participant Config
participant Logger
Main->>ChainClient: GetLatestHeight(ctx)
ChainClient-->>Main: Error occurs
Main->>Config: Check SkipChainAvailabilityCheck flag
alt Flag is false
Main->>Main: Panic
else Flag is true
Main->>Logger: Log the error
end
sequenceDiagram
participant SidecarQS as SidecarQueryServer
participant GRPCGateway
participant Logger
SidecarQS->>GRPCGateway: checkGRPCGatewayStatus()
GRPCGateway-->>SidecarQS: Error occurs
SidecarQS->>Logger: Log error ("Error checking grpc gateway status")
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This PR enables to start SQS service without early exit when Node is not available.
New behaviour is controlled with configuration variable to avoid discrepancies for the current setup with a defaults for early exit.
Feature can be tested with following command:
SQS_SKIP_CHAIN_AVAILABILITY_CHECK=true go run app/*.goNote: we don't need here any additional mechanisms since auto reconnect is handled by gRPC.
Summary by CodeRabbit