-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Added CLI output for --probes #4391
Conversation
d13c0e1
to
1703089
Compare
This pull request has been marked stale because it has been open for 10 days with no activity |
I'll note there's also go run main.go --repo=github.com/ossf-tests/scorecard-check-branch-protection-e2e --probes=fuzzed --format probe | jq
|
Signed-off-by: Eddie Knight <[email protected]> Applied review feedback Signed-off-by: Eddie Knight <[email protected]> Apply suggestions from code review Signed-off-by: Eddie Knight <[email protected]> typofix Signed-off-by: Eddie Knight <[email protected]>
b486c92
to
07cb181
Compare
fmt.Fprintf(os.Stderr, "[%s] Remediation required: %s\n", result.Probe, result.Remediation.Text) | ||
} else { | ||
fmt.Fprintf(os.Stderr, "[%s] Passed: %s\n", result.Probe, result.Message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How important are these exact phrases to your use case? Just informational?
I ask because I may want this cleaned up in the future/follow-up to be part of AsString. I'm not sure what it would look like, but being able to send the string to os.Stdout
or the specified --output
file would be good long-term.
I lost momentum on this effort, and I'm not sure it's entirely relevant since we now know that there is a solution via --output. I'm closing this for now to clear it from the repo's PR backlog. |
What kind of change does this PR introduce?
🐛 Bugfix
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)