✨ New probe for required MFA #4398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Knight <[email protected]>
eddie-knight
temporarily deployed
to
integration-test
GitHub Actions
Inactive
eddie-knight
force-pushed
the
mfa-probe
branch
from
1b9a198
to
db71e3d
Compare
eddie-knight
had a problem deploying
to
integration-test
GitHub Actions
Failure
eddie-knight
force-pushed
the
mfa-probe
branch
from
db71e3d
to
76b2b23
Compare
eddie-knight
had a problem deploying
to
integration-test
GitHub Actions
Failure
eddie-knight
force-pushed
the
mfa-probe
branch
from
76b2b23
to
bd121c3
Compare
eddie-knight
temporarily deployed
to
integration-test
GitHub Actions
Inactive
eddie-knight
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Eddie Knight <[email protected]> linting Signed-off-by: Eddie Knight <[email protected]> updated docs Signed-off-by: Eddie Knight <[email protected]>
eddie-knight
force-pushed
the
mfa-probe
branch
from
75aa405
to
77aeb54
Compare
eddie-knight
temporarily deployed
to
integration-test
GitHub Actions
Inactive
eddie-knight
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
|
Note that this follows #4391 |
raghavkaul
reviewed
Nov 4, 2024
| @@ -204,6 +204,17 @@ func (client *Client) GetCreatedAt() (time.Time, error) { | |||
| return client.repo.CreatedAt.Time, nil | |||
| } | |||
|
|
|||
| func (client *Client) GetMFARequired() (required bool, err error) { | |||
| org, _, err := client.repoClient.Organizations.Get(context.Background(), client.repourl.owner) | |||
There was a problem hiding this comment.
Could we add e2e tests of this on:
- repo owned by a user
- repo owned by an organization
| @@ -236,6 +236,11 @@ func (client *Client) GetCreatedAt() (time.Time, error) { | |||
| return client.project.getCreatedAt() | |||
| } | |||
|
|
|||
| func (c *Client) GetMFARequired() (required bool, err error) { | |||
There was a problem hiding this comment.
Appears this is available on GitLab for group namespaces as well:
https://docs.gitlab.com/ee/api/groups.html
Comment on lines
+18
to
+21
| motivation: > | ||
| What is the motivation for this probe? | ||
| implementation: > | ||
| How does this probe work under-the-hood? |
There was a problem hiding this comment.
Could you add these fields to the documentation?
Co-authored-by: Raghav Kaul <[email protected]> Signed-off-by: Eddie Knight <[email protected]>
eddie-knight
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Comment on lines
46
to
+47
| GetDefaultBranch() (*BranchRef, error) | ||
| GetMFARequired() (bool, error) |
There was a problem hiding this comment.
We may want to reach a decision on #4049
This is technically a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
New Probe to check whether an organization has MFA enabled. Requires an authorized token. Only supports GitHub in the present state.
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)