-
Notifications
You must be signed in to change notification settings - Fork 573
🌱 add support for trivy SAST tool #4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4685 +/- ##
==========================================
+ Coverage 66.80% 68.28% +1.47%
==========================================
Files 230 249 +19
Lines 16602 18890 +2288
==========================================
+ Hits 11091 12899 +1808
- Misses 4808 5131 +323
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
This pull request has been marked stale because it has been open for 10 days with no activity |
This pull request has been marked stale because it has been open for 10 days with no activity |
searchRequest: clients.SearchRequest{ | ||
Query: "github/codeql-action/analyze", | ||
Path: "/.github/workflows", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's revert the search request changes in this file like in 7846164
checkRuns: []clients.CheckRun{ | ||
{ | ||
Status: "completed", | ||
Conclusion: "success", | ||
App: clients.CheckRunApp{ | ||
Slug: "aqua-security-trivy", | ||
}, | ||
}, | ||
{ | ||
Status: "completed", | ||
Conclusion: "success", | ||
App: clients.CheckRunApp{ | ||
Slug: "aqua-security-trivy", | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment about checkRuns reverts
7846164#diff-d8b8a85f712c853eb9ef66ae055c6b18ad46f699b2b55606953c2af654af5ffbL354-L373
tests will need fixed too |
This pull request has been marked stale because it has been open for 10 days with no activity |
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
feature
What is the current behavior?
Scorecard does not support trivy SAST tool.
What is the new behavior (if this is a feature change)?**
Scorecard supports trivy SAST tool when using the official action.
Which issue(s) this PR fixes
Fixes part of #2318 (comment)
Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes