Skip to content

fix: deduplicating frameworks data #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: deduplicating frameworks data #370

wants to merge 1 commit into from

Conversation

eddie-knight
Copy link
Contributor

No description provided.

@funnelfiasco funnelfiasco force-pushed the fix/deduplicate-frameworks branch from 788d36c to 468e5fc Compare August 12, 2025 13:50
SecurityCRob
SecurityCRob reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@SecurityCRob SecurityCRob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will this data be stored going-forward? I can not suss that out here in the gui.

@funnelfiasco
Copy link
Contributor

Where will this data be stored going-forward? I can not suss that out here in the gui.

It's stored in baseline/metadata.yaml, which is where most of the tooling pulls from, except, as we discovered in this PR, the OSCAL piece.

@eddie-knight
Copy link
Contributor Author

Yep, this is only being used by the OSCAL parser currently.

@zohayb23 is working on a Gemara PR that will enable OSCAL conversion using metadata.yaml

I'll mark this as draft until that Gemara feature is available.

@eddie-knight eddie-knight marked this pull request as draft August 14, 2025 20:27
@funnelfiasco funnelfiasco added the blocked Waiting for an external action/input. label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SecurityCRob SecurityCRob SecurityCRob left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blocked Waiting for an external action/input.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddie-knight @funnelfiasco @SecurityCRob