Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve http response when err happens. #4073

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

suzp1984
Copy link
Contributor

@suzp1984 suzp1984 commented May 29, 2024

  1. response 200 with code when rtc/v1 remote sdp parse error;
  2. response 500 when no handled err.

Try to improve two problem:

  1. let rtc/v1/[whep|whip] response 200 with body {code : 400} when remote_sdp parse error happen by follow rtc/v1/[play | publish] api's response. The current behavior in this scenario is close the connection without response anything.

  2. Let SrsHttpServeMux response 500 when err not handled, the current behavior is also to close the socket connection without response anything.

1. response 200 with code when rtc/v1 remote sdp parse error;
2. response 500 when no handled err.
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants